search

gulp-community / gulp-footer

Gulp extension to add a footer to file(s) in the pipeline
MIT License
9 stars 9 forks source link

Package Dependency Issue in Version 1 #10

Closed selected-pixel-jameson closed 2 years ago

selected-pixel-jameson commented 6 years ago

The issue with the lodash dependency is still in version 1. It appears as though the update got pushed out to version 1 as well as version 2. The package dependency issue is a problem with version 1 still. If you could please fix it as soon as possible it would be greatly appreciated.

tracker1 commented 6 years ago

can you bump to version 2? I'll try to back publish 2 to 1 since the interface didn't change later, firewall permissions at work are wonky

selected-pixel-jameson commented 6 years ago

No, this is a dependency within gulp-angular-template cache module which isn't a repository I own so I'd have to get them to update that and fix any breaking changes.

mpriya05 commented 6 years ago

i am facing the same issue with lodash depenedency.

Error i am facing is Error: Cannot find module 'lodash._reinterpolate'[0m

(/../ux/node_modules/gulp-angular-templatecache/node_modules/gulp-footer/template.js:6:21)

Tempalte.js is using lodash._reinterpolate as dependecy, but this is not included in gulp-footer's package.json.

we had our staging code verified two weeks back and things was working fine.. when we redeployed to plan for a production rollover, this is causing an issue.

Could you please fix it ASAP. Appreciate your help.

tracker1 commented 6 years ago

published as 1.1.2 sorry for the delay

Also, it looks like gulp-angular-templatecache is using a pinned version, so won't get any other than what they have specified. I've submitted a PR to their repo for the update...

blasky commented 6 years ago

It appears I have 1.1.2 coming in through templatecache. But it fails to build with...

TypeError: undefined is not a function at .../node_modules/gulp-angular-templatecache/node_modules/gulp-footer/index.js:12:46

Apears to be related to the shift from .gulp-util to .template on 1/16/18. (But template cache didn't pull 1.1.2 in until today so that code didn't execute on my system until today.)

tracker1 commented 6 years ago

@blasky what node version are you using?

tracker1 commented 2 years ago

Closing as stale.