Replaced event-stream with direct dependency

Basa0 commented 5 years ago

es.map is a direct use of the map-stream package

simonua commented 5 years ago

This solution fixes #11 in a more elegant way rather than pinning a specific version of event-stream.

simonua commented 5 years ago

Hi @tracker1, if you can review and complete this PR, we can immediately use it in gulp-angular-templatecache#168.

Thank you!

DanielRuf commented 5 years ago

It's from the same author so it makes not much difference. But the real difference is, that event-stream is now owned by npmjs so there is a less risk, that something happens.

tracker1 commented 5 years ago

I'll try and look through this tomorrow evening... Will probably pin the version as suggested for a patch release, then do a full version release with the dependency change. Other input welcome.

simonua commented 5 years ago

@tracker1, awesome! Pinning the version in the interim gives us the assurance we need for gulp-angular-templatecache. I'll stay tuned for an updated package and will subsequently complete the aforementioned PR. Thanks very much!

@DanielRuf, you have a very good point regarding npm ownership, I think. That lends immediate credibility. One approach is not necessarily better than the other, but what made me favor getting rid of event-stream entirely are these thoughts:

event-stream now has a stigma. For someone to understand that 3.3.6 was the nefarious package they heard or read about may be less applicable than for someone to simply think they ought to stay away from anything with event-stream entirely.
Even though the same author is involved here, pinning the version of the replacements is as applicable as pinning the version of event-stream. You're right in that the versions are locked after 24 hrs (and can then only be removed with npm's help (left-pad, anyone?))
event-stream is a bit of a grab-bag with some added functionality, it appears. Sort of loosely reminds me of gulp-util, which the ecosystem rid itself of mostly, if not entirely. Using one or two individual packages is better than installing the entire grab bag module (so long as that is not negated by another package in your module using event-stream...).

simonua commented 5 years ago

Hi @tracker1, have you had a chance to look at this yet, please?

Thank you!

tracker1 commented 5 years ago

Published gulp-footer@2.0.2

tracker1 commented 5 years ago

@simonua @Basa0 @DanielRuf Sorry for the delay, this had slipped my mind.

simonua commented 5 years ago

No problem at all, @tracker1! Appreciate your time and follow-up. Thank you!

gulp-community / gulp-footer

Replaced event-stream with direct dependency #13