gulp-community / gulp-footer

Gulp extension to add a footer to file(s) in the pipeline
MIT License
9 stars 9 forks source link

Missing dependency lodash._reinterpolate #8

Closed mgroenhoff closed 6 years ago

mgroenhoff commented 6 years ago

template.js depends on lodash._reinterpolate but it is not a dependency (lodash.template has it but you can not rely on this).

selected-pixel-jameson commented 6 years ago

I'm also seeing this issue when using the gulp-angular-template cache module.

Error: Cannot find module 'lodash._reinterpolate'
    at Function.Module._resolveFilename (module.js:325:15)
    at Function.Module._load (module.js:276:25)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/Users/xxxxx/Documents/xxxx/website/www/user/node_modules/gulp-angular-templatecache/node_modules/gulp-footer/template.js:6:21)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
selected-pixel-jameson commented 6 years ago

Submitted a PR for this. https://github.com/tracker1/gulp-footer/pull/9

tracker1 commented 6 years ago

Sorry, merged PR and pushed/published

mgroenhoff commented 6 years ago

Thanks!

selected-pixel-jameson commented 6 years ago

@tracker1 I'm not exactly sure how publishing updates works, but it appears as though this update has gotten pushed out to version 1 as well as version 2. The package dependency issue is a problem with version 1 still. If you could please fix it as soon as possible it would be greatly appreciated.

selected-pixel-jameson commented 6 years ago

@tracker1 Any progress on this?

mpriya05 commented 6 years ago

I am facing the same issue. we need to push the code to production asap. it was planned for this friday.

I'm seeing this issue when using the gulp-angular-template cache module.

[19:32:00] Error: Cannot find module 'lodash._reinterpolate'[0m (../ux/node_modules/gulp-angular-templatecache/node_modules/gulp-footer/template.js:6:21)[0m