search

gulp-sourcemaps / identity-map

Gulp plugin for generating an identity sourcemap for a file.
MIT License
3 stars 7 forks source link

Support ES2018 syntax by upgrading acorn #6

Closed tchetwin closed 5 years ago

tchetwin commented 5 years ago

In order to provide identity sourcemaps for JavaScript with ES2018 syntax it's necessary to update the parser.

This PR bumps the major version of acorn from 5 to 6 to achieve this.

The acorn release notes for major version 6 are here. In particular the breaking changes listed are:

Breaking changes

The default value of the ecmaVersion option is now 9 (2018).

Plugins work differently, and will have to be rewritten to work with this version.

The loose parser and walker have been moved into separate packages (acorn-loose and acorn-walk)

I don't think these pose a problem here.

Also included is a test fixture that fails without the changes and some tweaks to pass the lint checks.

phated commented 5 years ago

@tchetwin this looks great! Do you see any issue with me bumping the major version just incase there are unintended consequences of the acorn major bump?

phated commented 5 years ago

Thanks again @tchetwin! I'll get this released in a major.

phated commented 5 years ago

2.0.0 was just released! https://www.npmjs.com/package/@gulp-sourcemaps/identity-map