search

gulpjs / async-done

Allows libraries to handle various caller provided asynchronous functions uniformly. Maps promises, observables, child processes and streams, and callbacks to callback style.
MIT License
70 stars 21 forks source link

npm test aborts due to lint style errors #38

Closed BurtHarris closed 7 years ago

BurtHarris commented 7 years ago

Now you've done it, got me interested enough to clone, build, and test. 👍

Running the command npm test gives me 7 minor issues, and exits with failure. They are all basically like this:

Invalid line break at test/streams.js :
     1 |'use strict';
---------------------^
     2 |
     3 |var expect = require('expect');

7 code style errors found.

I don't know your lint style, is it objecting to the semicolon, or something about the line break?

I'm on a Windows 10 machine if it matters, running node v6.10.3 and npm v5.0.3.

BurtHarris commented 7 years ago

Just checked, it's the CRLF style line endings that seem to be the issue. git's default behavior seems to convert line endings to the local convention when I cloned the project, but it stores them back in the repository in neutral form.

I would suggest that based on this, having lint enforce this rule is heavy-handed unless something goes into the project telling git to not convert line endings.

phated commented 7 years ago

I'm open to a .gitattributes file that forces text eol=lf - feel free to submit.