search

gulpjs / async-done

Allows libraries to handle various caller provided asynchronous functions uniformly. Maps promises, observables, child processes and streams, and callbacks to callback style.
MIT License
69 stars 21 forks source link

Investigate using node core functions #56

Closed phated closed 2 years ago

phated commented 2 years ago

In node 10, I believe they added stream.finished as the core implementation of the end-of-stream module. We should look into using that instead of relying on another dependency.

phated commented 2 years ago

Reviewed this and node core explicitly removed child_process handling from their implementation. We'd have to re-implement all of the handling logic just to add the 'exit' event, so I don't think it's worth it.