search

gulpjs / fancy-log

Log things, prefixed with a timestamp.
MIT License
121 stars 21 forks source link

Code minified #10

Closed lmfresneda closed 7 years ago

lmfresneda commented 7 years ago
lmfresneda commented 7 years ago

I don't know why Travis fails :(

$ npm install 
/home/travis/.nvm/versions/node/v0.12.18/lib/node_modules/npm/lib/config/cmd-list.js:113
module.exports.aliases = Object.assign({}, shorthands, affordances)
                                ^
TypeError: undefined is not a function
    at Object.<anonymous> (/home/travis/.nvm/versions/node/v0.12.18/lib/node_modules/npm/lib/config/cmd-list.js:113:33)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at /home/travis/.nvm/versions/node/v0.12.18/lib/node_modules/npm/lib/npm.js:37:17
    at Object.<anonymous> (/home/travis/.nvm/versions/node/v0.12.18/lib/node_modules/npm/lib/npm.js:471:3)
    at Module._compile (module.js:460:26)
jonschlinkert commented 7 years ago

I don't know why Travis fails :(

The error message says that Object.assign is undefined. The .assign method was introduced in ES 2015, but the node engine in package.json of this project is >= 0.10.0

lmfresneda commented 7 years ago

Hi! Thanks for the quick reply!

It is true that it is not necessary, but I find it interesting because the (little) code does not need exhaustive maintenance.

About the error, why it happens? I don't use 'Object.assign'... or I'm missing something...

phated commented 7 years ago

Thanks for the PR but we're going to pass on this.