search

gulpjs / fined

Find a file given a declaration of locations.
MIT License
12 stars 6 forks source link

Replace lodash dependencies #8

Closed sttk closed 7 years ago

sttk commented 7 years ago

This is a PR for #7

phated commented 7 years ago

I'd prefer if we didn't re-implement the methods. I think @jonschlinkert was using other modules

sttk commented 7 years ago

I rewrote to use other modules instead of re-implemented codes.

sttk commented 7 years ago

I've modified the codes.

sttk commented 7 years ago

I've added test/.eslintrc.

sttk commented 7 years ago

I've removed defaultNotNullish and filter-values, and used object.defaults as it is.

phated commented 7 years ago

@sttk this looks great! Did any of the external API change? Since we aren't filtering null-ish values, did the returned object shape change? I'm trying to determine what semver this should be released as.

phated commented 7 years ago

Based on none of the tests changing, I'm guessing the result hasn't changed and this can just be a minor version bump.

sttk commented 7 years ago

@phated This PR changes no external API. I just replaced lodash modules to other modules and codes.

And fined was already implemented for the cases like fined({ path: null }, {}) or fined({}, { path: null }) as returns null.

phated commented 7 years ago

Perfect, thanks!

sttk commented 7 years ago

Thanks for your help and merging!