Closed sttk closed 7 years ago
I'd prefer if we didn't re-implement the methods. I think @jonschlinkert was using other modules
I rewrote to use other modules instead of re-implemented codes.
I've modified the codes.
I've added test/.eslintrc.
I've removed defaultNotNullish
and filter-values
, and used object.defaults
as it is.
@sttk this looks great! Did any of the external API change? Since we aren't filtering null-ish values, did the returned object shape change? I'm trying to determine what semver this should be released as.
Based on none of the tests changing, I'm guessing the result hasn't changed and this can just be a minor version bump.
@phated This PR changes no external API. I just replaced lodash modules to other modules and codes.
And fined was already implemented for the cases like fined({ path: null }, {})
or fined({}, { path: null })
as returns null.
Perfect, thanks!
Thanks for your help and merging!
This is a PR for #7