search

gulpjs / glob-stream

Readable streamx interface over anymatch.
MIT License
178 stars 51 forks source link

fix: Traverse symlink folders #122

Closed joshhunt closed 7 months ago

joshhunt commented 8 months ago

https://github.com/gulpjs/glob-stream/pull/118 introduced a slight regression where symlinked directories would not be traversed during walkdir. This PR checks if dirents are symlinks + and traverses them as appropriate.

Fixes https://github.com/gulpjs/vinyl-fs/issues/349

joshhunt commented 7 months ago

Neat - thanks for the quick review and getting this one in @phated.

Do you think we could cut a release of vinyl-fs with this version? I'm happy to PR whatever's needed for that (just version bump?)

phated commented 7 months ago

@joshhunt It's actually unnecessary to release a new vinyl-fs, as we use the semver caret (^) to indicate ^8.0.0 which will pick up this release automatically! 🎉 Thanks again for your help here.

sunnysonx commented 7 months ago

On WSL, it introduced a bug with maximum call stack on i18next-scanner package.

Despite the fact that I do not have symlinks inside my project, it reaches the maximum call stack.

image

I have downgraded glob-stream to 8.0.0 and it resolved the issue.

All our current projects that were using i18next-scanner started to fail if glob-stream was updated to 8.0.1

joshhunt commented 7 months ago

@sunnysonx Please check in on the conversation in https://github.com/gulpjs/glob-stream/issues/125.

A reproduction, or some debugging to understand what path it is choking on would be appreciated 🙏

sunnysonx commented 7 months ago

@joshhunt I'm sorry, idk how it happened that I searched across all involved packages, but it seems that I ommited to search in glob-stream. Thank you