search

gulpjs / glob-stream

Readable streamx interface over anymatch.
MIT License
178 stars 51 forks source link

fix: Do not start and end the stream prematurely (#135) #136

Open pavelhoral opened 5 months ago

pavelhoral commented 5 months ago

This PR fixes premature start of the glob stream which can lead to closing the resulting Transform stream before it is being properly processed by upstream components. This can lead to very strange race conditions and unfinished pipelines.

phated commented 5 months ago

This is awesome. Thanks for debugging and adding a regression test! I think we can actually leverage the open function in streamx for this.

pavelhoral commented 5 months ago

This is awesome. Thanks for debugging and adding a regression test! I think we can actually leverage the open function in streamx for this.

Not sure why, but moving the code to open function breaks the pipeline completely. Seems like open state is too soon for data being produced by the stream.

UPDATE: I am dumb... forgot about the callback.

pavelhoral commented 5 months ago

Pushed new changes (switch to open method).

pavelhoral commented 4 months ago

Any update on this? Is there anything else I can do? Ty.

pavelhoral commented 1 month ago

Any update on this? Is there anything else I can do? Ty.

Would love to have this merged and released. If there is anything I can do to help that, let me know.