search

gulpjs / glob-stream

Readable streamx interface over anymatch.
MIT License
178 stars 53 forks source link

Finish the TODO for gulp.src list of globs orderings. #22

Closed bradobro closed 10 years ago

bradobro commented 10 years ago

@contra, I want to follow up on a TODO code comment by you near index.js:85:

    var uniqueStream = unique('path');
    // TODO: set up streaming queue so items come in order
    return aggregate.pipe(uniqueStream);

Are you thinking this is still a possible PR for Gulp now, something that should wait for Gulp 4, or something that doesn't belong in Gulp core.

I see this issue has drifted across several repos and caused more than a little aggravation; I bring it up here because it seems the best point in the code to introduce a consistent way to make gulp.src([...list-of-globs...] align with the ordering documented in gulp's readme:

Files will be concatenated in the order that they are specified in the gulp.src function. For example, to concat ./lib/file3.js, ./lib/file1.js and ./lib/file2.js in that order, the following code will create a task to do that.

yocontra commented 10 years ago

AFAIK This already works - If you give gulp.src an array of globs it will do each glob in order

bradobro commented 10 years ago

Okay. Closing for now until I can confirm in code.

bradobro commented 10 years ago

You are right @contra, the ordering works sanely. '`gulp.src([glob,glob,...]) emits the vfs files from globs sequentially. Apologies for the false issue.

yocontra commented 10 years ago

No problem, I'll remove that comment