search

gulpjs / glob-stream

Readable streamx interface over anymatch.
MIT License
178 stars 53 forks source link

100% coverage #34

Closed UltCombo closed 9 years ago

UltCombo commented 9 years ago

This is the only line of code that is not covered yet: https://github.com/wearefractal/glob-stream/blob/1f26389f0408ed33201c17f4658b882242fde881/index.js#L105

The return true doesn't make much sense to me, should we throw an error instead? Then we can just add a test to cover that.

UltCombo commented 9 years ago

Or perhaps, return false if you'd prefer to fail silently. Though throwing would make more sense, IMO.

yocontra commented 9 years ago

Should throw on unknown glob type or invalid glob on construction of the stream, then this check can be removed