Throw on invalid glob, clean up, 100% coverage, closes #34

gulpjs / glob-stream

Readable streamx interface over anymatch.

MIT License

178 stars 53 forks source link

Throw on invalid glob, clean up, 100% coverage, closes #34 #35

Closed UltCombo closed 9 years ago

UltCombo commented 9 years ago

Better naming for negative matchers ( https://github.com/wearefractal/glob-stream/pull/33#issuecomment-68514070 )
Throw on invalid glob argument ( https://github.com/wearefractal/glob-stream/issues/34#issuecomment-68513629 )
Removed the if (!Array.isArray(globs)) return gs.createStream(globs, [], opt); because this optimization is already covered a couple lines below at if (positives.length === 1) return streamFromPositive(positives[0]);, and to not duplicate the validation code. Previously, passing a string with a negative glob did not throw a "Missing positive glob" error, now it does.

coveralls commented 9 years ago

Coverage increased (+1.49%) when pulling 989d1626f0292eda667e7762161d43c905a10f73 on UltCombo:clean-up into 2768041f6bdddd25c3ad3ed520d682995a44e06d on wearefractal:master.

UltCombo commented 9 years ago

Shiny 100% :smiley_cat:

UltCombo commented 9 years ago

Thinking again, the matcher idea is pretty pointless now that node-glob is about to land the ignore API, I'll revert that part.

coveralls commented 9 years ago

Coverage increased (+1.49%) when pulling cf6001961ff6ba6d66391d743869eaf64b0bc95e on UltCombo:clean-up into 2768041f6bdddd25c3ad3ed520d682995a44e06d on wearefractal:master.

coveralls commented 9 years ago

Coverage increased (+1.49%) when pulling 4e4be7533d2e57b7fdf2aaa80ebe65f93d79588d on UltCombo:clean-up into 2768041f6bdddd25c3ad3ed520d682995a44e06d on wearefractal:master.

coveralls commented 9 years ago

Coverage increased (+1.49%) when pulling 17381e73e8fa90a0b3acb22c2858e764c153d578 on UltCombo:clean-up into 2768041f6bdddd25c3ad3ed520d682995a44e06d on wearefractal:master.

UltCombo commented 9 years ago

PTAL.

yocontra commented 9 years ago

Nice and clean now - thanks!