Fix root option on glob

gulpjs / glob-stream

Readable streamx interface over anymatch.

MIT License

178 stars 53 forks source link

Fix root option on glob #38

Closed Janpot closed 9 years ago

Janpot commented 9 years ago

Fixes https://github.com/wearefractal/glob-stream/issues/37

coveralls commented 9 years ago

Coverage decreased (-3.7%) to 96.3% when pulling 985eddf99bbd3f33c67ee4340058afb820cf41ea on Janpot:fix-glob-root-option into 6411ea4891d24227f94f302bd52d79584af8fa9b on wearefractal:master.

Janpot commented 9 years ago

ok, bad test + coverage, let me fix this

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling c276d5d52d4da909ed11a2610225a58011d77378 on Janpot:fix-glob-root-option into 6411ea4891d24227f94f302bd52d79584af8fa9b on wearefractal:master.

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling f7608bf49a0e271607dd3011916b8d18bed88806 on Janpot:fix-glob-root-option into 6411ea4891d24227f94f302bd52d79584af8fa9b on wearefractal:master.

yocontra commented 9 years ago

rebase?

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling de2f38bfcd420a3215649ce77a1be8e014f9f06c on Janpot:fix-glob-root-option into 0839bdd1556cce4a352ca0fcf55ed1b1ed817fb0 on wearefractal:master.

Janpot commented 9 years ago

@contra done

yocontra commented 9 years ago

Needs docs on what the root option does

Janpot commented 9 years ago

@contra It's already documented here: https://github.com/wearefractal/glob-stream#options

This argument is passed directly to node-glob so check there for more options

Which leads to:

root The place where patterns starting with / will be mounted onto. Defaults to path.resolve(options.cwd, "/") (/ on Unix systems, and C:\ or some such on Windows.)

Janpot commented 9 years ago

@contra Can you give some more input on which extra docs you expect for this PR? In my opinion no extra doc is needed as this is only a bugfix on an existing feature.