search

gulpjs / glob-stream

Readable streamx interface over anymatch.
MIT License
178 stars 53 forks source link

gs.create(['file1.txt', 'file2.txt']) only returns file1.txt #5

Closed lazd closed 10 years ago

lazd commented 10 years ago

Providing a glob array correctly builds 2 streams, then tries to combine them with stream-combiner, but the aggregate stream only emits data for the first glob.

This may be a stream-combiner issue: https://github.com/dominictarr/stream-combiner/issues/1

lazd commented 10 years ago

I found something interesting. The aggregate stream will end if any of the combined streams end. Therefore, commenting out the following line seems to fix the problem:

https://github.com/wearefractal/glob-stream/blob/master/index.js#L53

However, I don't know what implications that will have...

yocontra commented 10 years ago

@lazd Hmm that is 100% not the correct behavior. It should end when all streams it combined end. Very strange. I can hack that in for now.

yocontra commented 10 years ago

Fixed in glob-stream 3.0.3