search

gulpjs / glob-stream

Readable streamx interface over anymatch.
MIT License
178 stars 53 forks source link

Resolve basePath first #67

Closed doowb closed 8 years ago

doowb commented 8 years ago

This PR resolves the basePath before expanding the glob into an absolute path. This is necessary for when paths contain "glob like" characters but aren't part of the actual glob pattern.

I wanted to get this up here for review. I'll be able to add a test for the specific gulp issue later today.

yocontra commented 8 years ago

Seems good, @phated ?

doowb commented 8 years ago

Thanks @contra. I moved the .base check outside of the function and I'm using ourOpts now since I know it will be an object at that point.

phated commented 8 years ago

LGTM.

@doowb it's really awesome and very much appreciated that you can jump on issues like these and get them patched up (throughout the gulpjs org).

doowb commented 8 years ago

Thanks @phated, I'm glad I can help.