Should `create` accept a non-array ignore option

gulpjs / glob-stream

Readable streamx interface over anymatch.

MIT License

178 stars 51 forks source link

Should `create` accept a non-array ignore option #77

Closed phated closed 8 years ago

phated commented 8 years ago

We normalize many options passed to node-glob and we are combining ignore and negative globs so it might make sense to normalize a string for ignore to an array (node-glob only accepts an array).

Kind of dependent on #74

erikkemperman commented 8 years ago

@phated ~~Can't hurt to do it here I suppose, but not strictly necessary with up-to-date glob? https://github.com/isaacs/node-glob/blob/master/common.js#L31-L32~~

Aargh, nevermind, I guess it's still not strictly necessary but not for the reason I thought this morning (but because concat accepts single values as well as arrays).

It's just that I happened to see the isArray check in glob and then here in quick succession.

phated commented 8 years ago

Ah, I'll keep it here then.