search

gulpjs / glob-stream

Readable streamx interface over anymatch.
MIT License
178 stars 51 forks source link

Bump dependencies #80

Closed shinnn closed 8 years ago

shinnn commented 8 years ago

glob-stream becomes modern Stream3 implementation by this PR.

phated commented 8 years ago

Thanks. I am trying to solve some other problems before bumping the dependencies. Going to close this and do it once I land the other changes.

shinnn commented 8 years ago

OK. But please remember that this commit is essential to upgrade to Stream3.

Or, should I remove the last commit and rename this PR to "Pass data to the stream correctly"?

phated commented 8 years ago

TBH, this probably shouldn't even be using a Transform stream since it is using it like a readable. I need to investigate more.

phated commented 8 years ago

@shinnn some initial work at https://github.com/gulpjs/glob-stream/commit/8260e0a2d84ee4f3d82fc38c8035e958c1a60899 but I'm waiting for some answers to questions from isaacs on node-glob and I need to refactor the tests because they expect an end event without being drained right now.