search

gulpjs / gulp-cli

Command Line Interface for gulp.
MIT License
401 stars 106 forks source link

chore!: Normalize repository, dropping node <10.13 support #239

Closed sttk closed 11 months ago

sttk commented 2 years ago

This PR updates this repository for the following points:

  1. Upgrades dependencies and drops node <10.13 support

    • yargs's version is 16, not latest, because the latest version 17 supports node >=12.
    • marked-man version is 0.7, because the latest version 1.3 is esm.
    • eslint, expect, and mocha upgrades to the last versions which supports node v10.
    • Other dependencies upgrades latest versions.

  2. Stops using gulp-test-tools

    Because gulp-test-tools was used for nodejs v0.10.

  3. Replaces ansi-color and color-suuport to chalk

    Because this package used chalk originally, and chalk enables to drop the codes for --color/--no-color flags.

  4. Drops isobject and array-sort

    By adding alternative codes.

  5. Drops old gulp supports

    This PR removes ^3.7.0, ^4.0.0-alpha.1, and ^4.0.0-alpha.2 directories.

  6. Change directory configuration.

sttk commented 2 years ago

I'll make a PR for using theming-log after this PR.

phated commented 1 year ago

@sttk why did you remove support for gulp 3.x? This package is supposed to support all versions of gulp we can.

sttk commented 1 year ago

@phated Since gulp-cli is added dependencies of gulp, gulp-cli is not needed to install globally and we can think that new gulp-cli is used in new gulp. In addition, it's difficult that we'll continue to support gulp v3 on new node and new versions of dependencies. So I think it's better to remove supporting gulp v3.

sttk commented 1 year ago

@phated I've modified Liftoff.configFiles as I wrote in liftoff#126.

sttk commented 1 year ago

@phated I've reverted the two commits about dropping old gulp supports and changing directory configuration. Please review this PR again.

sttk commented 1 year ago

@phated I've done except the matter regarding archy, pretty-hrtime, and merging config by mergeConfigToCliFlags, mergeConfigToEnvFlags. It will take a little more time for these remaining matter, so please wait for a while.

sttk commented 1 year ago

@phated All changes have been completed. Please review this PR again. :bow:

sttk commented 11 months ago

@phated I've modified what you pointed out. Please review again. :bow: