search

gulpjs / gulp-util

[deprecated] - See https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
MIT License
830 stars 103 forks source link

Allow for the PluginError constructor to be called without `new`. #77

Closed dead-claudia closed 8 years ago

dead-claudia commented 9 years ago

This also falls in line with the builtin Error types and most of the other builtins as well.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same when pulling 4e124b9e28dd2cec64218342dffedc18009e61ab on impinball:master into fb4df4bd416095ab591aa8d2119c495613bd5c8e on gulpjs:master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same when pulling d528546d072b91c14f727cac1364cf9eda85d9d2 on impinball:master into fb4df4bd416095ab591aa8d2119c495613bd5c8e on gulpjs:master.

sindresorhus commented 9 years ago

:-1: It should be explicit that it's a new instance.

yocontra commented 9 years ago

This will add a new item to the error stack and push other stuff off. You can manipulate the stack to remove PluginError from it

phated commented 8 years ago

Closing, as work shouldn't be done in this module anymore.