gulpjs / gulpjs.github.io

The gulp website
http://gulpjs.com
44 stars 44 forks source link

fetch from Open Collective using the latest API #103

Closed znarf closed 5 years ago

znarf commented 5 years ago

The current endpoint used is old and deprecated. See: opencollective/opencollective#2037

This PR update to a new REST endpoint that is linked to the Open Collective GraphQL API v2.

This is supported by the Open Collective Engineering team, so happy to help if there is any problem with the endpoint or the data returned.

Changes

phated commented 5 years ago

This is awesome! Thanks @znarf

One thing that I want to do before/when I merge this is use es5 syntax because we still have 5% of traffic from IE.

znarf commented 5 years ago

@phated What needs to be taken care of? Template literals? Destructuring assignment? Something else?

phated commented 5 years ago

I think template literals, destructuring and arrow functions.

znarf commented 5 years ago

@phated @terinjokes I think I now addressed your comments. Let me know if I can do anything else to move this PR forward.

phated commented 5 years ago

@znarf sorry I dropped this, it's been a busy couple of weeks. I started the server locally and I noticed our all-time top donor isn't showing up in the list. I'm guessing this is because he is no longer an active subscriber. Is there a way to get the list of top donors of all-time (instead of just active or inactive)?

znarf commented 5 years ago

@phated I amended the PR to do that. The list now looks pretty similar to the current one.

Capture d’écran 2019-07-02 à 09 30 09

phated commented 5 years ago

@znarf thanks for all the work here! It's looking great now!