Set search input size to 16px #119

dpanov commented 4 years ago

Fixes #119 .

Btw, the docs.css file looks like it could use some refactoring. Here's some stuff I was thinking of doing:

Change the file to be a SCSS file
Nest media queries inside CSS selectors (e.g. the way it's done in src/theme/BackerSection/backers.module.scss)
Group together the selectors - e.g. we are referencing .navbar__search-input in three different places. It will be easier to maintain if the CSS for the selector is in one place.
Lower the specificity of some selectors - this could be tricky, because 1. Infima has some unnecessary heavy selectors and 2. the CSS bundling is weird and puts the custom CSS (docs.css) somewhere in the middle of the output file and its selectors are being overwritten by other CSS.

If it's OK I can open a separate PR for these?

phated commented 4 years ago

@dpanov Thank you! I love all of your ideas. Happy to review any PRs that you send for those.

We might also loop in @yangshun and @lex111 if we need anything changed in Docusaurus or Infima (like the specificity).

lex111 commented 4 years ago

In fact, a few months ago, in the Infima repository (it is private), I opened a PR that removes redundant specificity, but so far that PR has not been reviewed, so this is a good reminder for @yangshun.

gulpjs / gulpjs.github.io

Set search input size to 16px #119 #120