search

gulpjs / gulpjs.github.io

The gulp website
http://gulpjs.com
45 stars 44 forks source link

config modification #131

Closed ghost closed 3 years ago

ghost commented 4 years ago
  1. Plugins : isProd seems occuring error
  2. Color mode change
  3. navbar parameter naming
  4. Footer title miss
ghost commented 4 years ago

Oh it seems I accidently changed through prettier. Will change to " to ' and mention here which code I changed manually.

ghost commented 4 years ago

I changed to single quote and seem you can check in fils changed exactly which has modified please confirm. 👍 https://github.com/gulpjs/gulpjs.github.io/pull/131/files

phated commented 4 years ago

Thank you for fixing that! I notice that it added commas also, but I'm those should be there anyway. I will review this and make suggestions this weekend.

phated commented 4 years ago

@donghwipark I just noticed that you have not committed any changes to the package.json and package-lock.json files, which need to be updated for the new version of docusaurus. Did you mistakenly leave out those updates?

ghost commented 4 years ago

It was a mistake, will pull request with package json

phated commented 3 years ago

@donghwipark it looks like you pulled/merged master instead of the source branch 😬

ghost commented 3 years ago

Yes I accidently pulled the master.. I pull request with another commit please confirm.