search

gulpjs / gulpjs.github.io

The gulp website
http://gulpjs.com
45 stars 44 forks source link

Docusaurus upgrade debugging #133

Closed ghost closed 3 years ago

ghost commented 3 years ago
  1. docusaurus-plugin-sass"from 0.1.08 to 0.1.11
  2. config modification
  3. Implement Navbar/index.js accordingly
phated commented 3 years ago

The algolia search box changed and needs styling updates to match our search box:

The changes make it look like this:

Screen Shot 2021-01-27 at 12 40 21 PM

But it should look like this:

Screen Shot 2021-01-27 at 12 43 09 PM

And on mobile:

Screen Shot 2021-01-27 at 12 49 12 PM

But should look like:

Screen Shot 2021-01-27 at 12 46 53 PM

I'm okay adjusting to to a dark-background search icon for mobile, but it would need to come with additional navbar updates to make things look proportionate.

phated commented 3 years ago

The word "logo" appears in the footer for some reason now:

Screen Shot 2021-01-27 at 12 46 09 PM
phated commented 3 years ago

The plugins page keyword lists got messed up:

Screen Shot 2021-01-27 at 12 45 41 PM Screen Shot 2021-01-27 at 12 45 47 PM

I assume this was a change with the underlying css library that we use from docusaurus

phated commented 3 years ago

We should also remove this patch https://github.com/gulpjs/gulpjs.github.io/pull/130 that was put into place to fix an issue until we upgraded past alpha.66

phated commented 3 years ago

@donghwipark let me know once you've completed those fixes and I will review again.

ghost commented 3 years ago

@phated I fixed the issues you mentioned above. Please confirm.