search

gulpjs / gulpjs.github.io

The gulp website
http://gulpjs.com
44 stars 44 forks source link

In Safari, when exiting the search box, the page jumps to the bottom #134

Open phated opened 3 years ago

phated commented 3 years ago

@donghwipark I just noticed this on the deployed website, do you want to try to fix it?

ghost commented 3 years ago

@phated Sure! Thank you for your support even you are on a busy schedule!

ghost commented 3 years ago

@phated I tried to define in what situation this bug occurs first.

  1. Case forced to scroll down not occur A. When the screen is on top
    • clicking ESC button
    • clicking outbound of the search popup B. When initially screen has moved down even 1 pixel
    • clicking ESC button after inputting some text
    • clicking outbound of the search popup after input some text C. When initially screen has moved down even 1 pixel
    • clicking ESC button after inputting some text more than 1 and delete till text become one
    • clicking outbound of the search popup after input some text more than 1 and delete till text become one
  2. Case forced to scroll down occurs A. When initially screen is moved down even 1 pixel
    • clicking ESC button
    • clicking outbound of the search popup B. When initially screen has moved down even 1 pixel
    • clicking ESC button after inputting some text and delete all the text
    • clicking outbound of the search popup after input some text and delete all the text C. When initially screen has moved down even 1 pixel
    • clicking ESC button after inputting one length of text(include 1 character)
    • clicking outbound of the search popup after input inputting one length of text(include 1 character)

So in conclusion this bug can define as below If the input count is 0 or 1 with even 1 pixel scrolling down, the scroll itself goes down to the bottom when you click "ESC" keyborad or click outside the pop-up window by mouse.

ghost commented 3 years ago

I shared the situation on discord. Hope I can get the support from the discord https://discord.com/channels/398180168688074762/584803742801723424

lex111 commented 3 years ago

@donghwipark actually this has been fixed in subsequent releases, just update the website to the first beta version.

ghost commented 3 years ago

@lex111 Thank you so much for the notification will try that way.

ghost commented 3 years ago

I retested below NG cases in the local environment after update the docusaurus from 2.0.0-alpha.70 to 2.0.0-beta.4

Case forced to scroll down occurs A. When initially screen is moved down even 1 pixel

Concern The new version of the header is not fixed on the screen. If you want to fix the header on scroll down please let me know @phated. Will commit the code on package.json update