search

gulpjs / gulpjs.github.io

The gulp website
http://gulpjs.com
44 stars 44 forks source link

Docusaurus version upgrade to 2.4.1 #148

Closed ghost closed 4 months ago

ghost commented 1 year ago

I updated to docusaurus v 2.4.1 Please check and comment if there is any fix requires. Thank you

phated commented 1 year ago

@donghwipark have you run the new changes against the website? I'm seeing a lot of differences. For example, the navbar isn't pinned to the top of the window when you scroll any more.

ghost commented 1 year ago

@phated I couldn't realize that defect. I will compare with current web and please let me know defects you realised. Will fix and re-commit.

ghost commented 1 year ago

@phated I fixed the CSS and pushed, please have a look and give me any comments if you need. Thank you

ghost commented 1 year ago

I found some changes on text size after the upgrade. Seems default css has changed will update and commit

ghost commented 1 year ago

@phated fixed some css after comparing between the new version and current version.

phated commented 1 year ago

@donghwipark that's awesome! Thanks for inspecting. Will you also please update the other dependencies that have newer versions? I noticed that docusaurus-plugin-sass and other packages are very outdated.

Also, please regenerate and commit the package-lock.json using npm i -S

ghost commented 1 year ago

@phated Sure Thank you for the guide!

phated commented 4 months ago

Replaced by #149