search

gulpjs / gulpjs.github.io

The gulp website
http://gulpjs.com
44 stars 44 forks source link

added in fourth item in feature box and adjusted mobile responsiveness #41

Closed chanonroy closed 7 years ago

chanonroy commented 7 years ago
screen shot 2017-01-03 at 5 48 44 pm

Looking to contribute more, holla if you need more help

yocontra commented 7 years ago

Copy is duplicated between this and the first item. You can revert the copy for the first item to what it used to be to rectify that.

chanonroy commented 7 years ago

Ah. Just noticed now.

Re: first item's old copy Is this the copy you're referring to? (from the marvelapp mockup) "By preferring code over configuration, gulp keeps things simple and makes complex tasks manageable"

Looking at the overall picture now, I can see why the 'Easy to Learn' feature item may have been omitted. Let me know if this is still a worthwhile effort. Otherwise, I can pick up on an official 'help wanted' issue.

yocontra commented 7 years ago

@chanonroy Yep, that copy. Title too. I think they're different enough to have both.

yocontra commented 7 years ago

@chanonroy It seems like the latest changes updated the existing copy to the old stuff, but didn't add the new section to replace the lost copy?

chanonroy commented 7 years ago

@contra - it didn't carry over from the first Pull Request commit? On my fork the new section with lost copy is still there. Did it have to do with the way that the last commit updated the Pull Request?

yocontra commented 7 years ago

Hmm, looks a little funky:

image

chanonroy commented 7 years ago

Hmm. It should not look like that. Checking now.

chanonroy commented 7 years ago

@contra - is this using the updated main.css? I copied the old stylesheet in and it looks funky like yours. The updated stylesheet from the commits achieve a look similar to the first photo I posted.

yocontra commented 7 years ago

@chanonroy I merged your whole PR so all the changes in here were deployed.

chanonroy commented 7 years ago

commit

I'm looking at the merge. I could be wrong, but I feel like every 'remove' line in red (#1) is something that I intended to add, and that every 'add' line in green (#2) is something that I intended to remove.

Something funky going on here.

chanonroy commented 7 years ago

Worse comes to worse, we can always revert it to the original with 3 feature boxes. This might be a lot of effort for very minimal changes.

yocontra commented 7 years ago

@chanonroy Reverted it while you work it out - send a new PR when ready.