search

gulpjs / gulpjs.github.io

The gulp website
http://gulpjs.com
44 stars 44 forks source link

Remove trailing slashes from links in plugin list #84

Closed unconfident closed 6 years ago

unconfident commented 6 years ago

Didn't find where sources of https://gulpjs.com/plugins/ page located so posting here instead.

NPM website has updated recently and now links containing a slash after package name do not resolve correctly, resulting in a 404 page. Compare: with, without

Code in question:

<!--                                          this slash ↴ -->
<a ng-href="https://www.npmjs.com/package/{{plugin.name}}/" target="_blank" title="Install" class="title" ng-bind="plugin.name"></a>
yocontra commented 6 years ago

Wow, that is really crummy behavior for their website. My gut says they should fix it, but if you send a PR to remove the slash we can merge it.

unconfident commented 6 years ago

I don't think plugins page is a part of this repository, at least I wasn't able to find it.

My gut says they should fix it

Yeah, I agree but knowing how it is, it will probably take them multiple years to do so. Maybe they iterate quicker on the website than they do on the cli tool though. I'm also not seeing a public repo with sources for their main website anywhere so maybe it's private

unconfident commented 6 years ago

Looks like they fixed it on their end, trailing slashes now removed with a redirect