search

gulpjs / gulpjs.github.io

The gulp website
http://gulpjs.com
45 stars 44 forks source link

Vinyl instance property table looks pretty bad #95

Open phated opened 6 years ago

phated commented 6 years ago

The way we have styling defined to have all the other tables looking good (on desktop and mobile) is causing the Instance Property table in Vinyl documentation to look really bad. It'd be nice to fix it in that one case but still keep the others the same.

attaradev commented 5 years ago

@phated I would be very grateful if you can throw more light on this issue

phated commented 5 years ago

@mikeattara the spacing for this table (https://gulpjs.com/docs/en/api/vinyl#instance-properties) doesn't look good. The description column doesn't get enough space while the throw column gets too much. I don't think we can target that table specifically without causing issues with the other tables.

APatil010 commented 5 years ago

@phated I am new to open source contribution, i tried a few ways to target the table intended, but was unsuccessful. I have a very naive solution, if that doesn't affect the ideology or views through which the documentation was created, where we can just swap those two columns, to make it much better. Any ideas on this or anything that you think of.

phated commented 4 years ago

@APatil010 with our new website upgrades, MDX is supported in all the documentation. We've already leverage this for https://raw.githubusercontent.com/gulpjs/gulp/master/docs/support/for-enterprise.md by adding custom classes to the code that is then styled on our website.

If you want to take another stab at this, feel free!