Update rechoir to fix #100

gulpjs / liftoff

Launch your command line tool with ease.

MIT License

840 stars 52 forks source link

Update rechoir to fix #100 #102

Closed sttk closed 5 years ago

sttk commented 5 years ago

This pr updates rechoir's version because this is the cause of #100.

phated commented 5 years ago

@sttk I'm a little nervous to release this as a 3.x version - the reason I bumped to 0.7 of rechoir was due to the multi-dot stuff being new behavior that might break someone. Should we wait to land this until we have the config file changes to release as a 4.0?

sttk commented 5 years ago

@phated I agree to wait this fix until next major version.

Probably this pr will cause no problem, because the latest rechoir resolves extensions from longer to shorter. But It's just a guess and I'm a little concerned about it, too.

(I modified test cases.)

phated commented 5 years ago

Now that there is a "Breaking" commit in the main repository, I'll merge this and we can group everything for the 4.0 release.