search

gulpjs / liftoff

Launch your command line tool with ease.
MIT License
840 stars 52 forks source link

Change timing of completion to enable to configure its error message #106

Closed sttk closed 3 years ago

sttk commented 5 years ago

This pr moves completion into execute method, because the current timing is before loading config files.

This modification is needed for gulp-cli#161.

phated commented 3 years ago

I believe this is breaking, since code might have assumed that execute was never run when completions were called, but otherwise looks good! I'll merge and update the commit message.

sttk commented 3 years ago

@phated Thank you for merging!