search

gulpjs / liftoff

Launch your command line tool with ease.
MIT License
843 stars 52 forks source link

feat!: Lookup configPath in configFiles #128

Closed phated closed 6 months ago

phated commented 6 months ago

In gulp-cli, we seem to have a lot of confusing code to try to fallback to the flags.gulpfile defined in the .gulp.js config file. Instead of all that code, we should just support it in liftoff.

phated commented 6 months ago

@sttk please review, as this is some cleanup that I want to do before translations and themes. I believe that simplifying the env override will allow me to more easily implement your suggestions in my prototype.

sttk commented 6 months ago

Additionally, would it be acceptable to override preload and nodeFlags within Liftoff, since they are both Liftoff options? (It might be ok in a separate PR.)

phated commented 6 months ago

@sttk I implemented the preloads in #131, please take a look. I also investigated the nodeFlags but I've decided not to include that until we support/handle the process.argv in Liftoff. I've opened #132 to track.