search

gulpjs / liftoff

Launch your command line tool with ease.
MIT License
840 stars 52 forks source link

Enable to configure v8flags in application #89

Closed sttk closed 6 years ago

sttk commented 6 years ago

This pr is for giving a liftoff application a change to configure node flags.

phated commented 6 years ago

@sttk thanks for submitting this. I'm keeping this in the back of my mind to see if we can solve it in a cleaner way.

phated commented 6 years ago

@sttk I'm just outlining some thoughts but what if this library took a argv option. If it is a function, it can received the buildEnvironment and return the argv it wants to use instead of process.argv. It seems more flexible that modifying the in-process process.argv object. Thoughts?

sttk commented 6 years ago

@phated I've rebased and tried to add opts.argv which can be specified an array or a function. Is this along with your thought?

phated commented 6 years ago

@sttk are you planning to update this soon to use the flagged-respawn updates?

sttk commented 6 years ago

@phated Yes, and I've recreated and pushed now!

sttk commented 6 years ago

I don't know the cause of the failure, but it succeeded on my test env.

phated commented 6 years ago

@sttk I'm not happy with the option name nodeFlags - I'll probably rename it in the merge.

phated commented 6 years ago

Merged as b3df2f5e1673ac3994dc07a4c1421148aac62737

@sttk Thank you so much for taking the time to solve this elegantly. I'm very happy with this implementation!

sttk commented 6 years ago

@phated I see and I think your naming is better. Thanks for merging.

phated commented 6 years ago

Published as 2.5