search

gulpjs / liftoff

Launch your command line tool with ease.
MIT License
843 stars 52 forks source link

Add beforeRequire event #92

Closed sttk closed 5 years ago

sttk commented 6 years ago

This is a pr for the issue #53.

This pr makes liftoff emit beforeRequire event, but for only a module which is specified by opts.require.

phated commented 6 years ago

@sttk I'm not trying to ignore your work but I've been taking a break from gulp because I'm trying to find a paid job (My girlfriend says I've been working for free on gulp too long).

sttk commented 6 years ago

@phated I'm OK. I'm in no hurry. I'm planning to send a few more pr but don't mind them until you have time.

phated commented 5 years ago

@sttk can you update this to fit with the other changes in Liftoff? I'd like to fit it into the 4.0 release.

sttk commented 5 years ago

@phated OK. I'll update this pr.

sttk commented 5 years ago

I've rebased this.

phated commented 5 years ago

Looks great! Thanks @sttk!

sttk commented 5 years ago

@phated Thanks for merging!