search

gulpjs / liftoff

Launch your command line tool with ease.
MIT License
840 stars 52 forks source link

Don't emit 'requireFail' when one of loaders succeeded. #94

Closed sttk closed 5 years ago

sttk commented 6 years ago

Because I think just 'require' event is enough when one of loaders succeeded.

phated commented 5 years ago

@sttk I'm thinking about this a bit more recently - are we planning to release a 2.6 of Liftoff or do we want to do a major (3.0) bump? If we are going to do a major bump, we could probably clean up this API in some ways.

sttk commented 5 years ago

@phated I agree with a major bump. I think we should reconsider about relations of cwd, configPath and modulePath, too. I found that requiring paths can be controlled with module.paths, so it's ok that the directories of these three paths are different. Since this will change current behavior, I think a major bump is better.

phated commented 5 years ago

This has been rebased and merged.

Closed by 35a3519cf4363e02a44bab2af5ab2b3a28492231

Amazing work, as always, @sttk

phated commented 5 years ago

@sttk btw, I marked this as a "fix" in the commit history - maybe that is incorrect and we should actually make it an "update" and then cut this as 2.6.0

I don't think this should be a major because it's just changing the logging in the CLI.

phated commented 5 years ago

I've rebased and force-pushed the "update" label on that commit. I'll tag it as 2.6.0 and publish it tonight.

phated commented 5 years ago

Ugh. I'm actually a liar and I decided to release it as a major release. Going to force push 1 more time and cut the 3.0 release.

phated commented 5 years ago

@sttk 3.0.0 published!

sttk commented 5 years ago

@phated Thank you a lot for reviewing, merging and bumping major version!