Closed silkentrance closed 9 years ago
And maybe we can get rid of resolve-sync altogether now that we have the module's require() function?
I do not know, however, if require
and module.require
are essentially the same function, as require
has a few more properties assigned to it.
According to http://nodejs.org/api/modules.html#modules_module_require_id they behave exactly the same.
@tkellen merged master, all seems to be well
Can you rebase to a single commit and then we'll merge this?
Uh oh, never done this before. Will try. Also need to add parameter checking.
Hope that the latest commit does the trick...
Erm, rebasing with published commits seems to be a no-no... Well, cherry pick then? Otherwise I will tear down the branch and recreate it and then we can merge the single commit in the new branch.
if you rebase/squash you can force push over your old commits and this will automatically update the PR
Seems to be ok, when trying to push I get 'everything is up to date'... and I already did the merge, so... you can simply merge 19110c2 as it already contains the changes merged from master...
Okay, forced push, forgot to rebase --continue...
Thanks for pointing me towards rebase!
With load() going to be removed this is now obsolete.
Have a look. I know that this will break the existing API. It will, however, make the behavior of load() similar to require() so that load() can be used as a drop-in replacement.
This might even go so far as to register the load function as the new require function in the user module, e.g.
What do you think?