search

gulpjs / update-template

Updates a gulpjs repository to match our current scaffold.
MIT License
3 stars 4 forks source link

CI: eslint failure #3

Closed coreyfarrell closed 4 years ago

coreyfarrell commented 4 years ago

What were you expecting to happen?

eslint . to succeed

What actually happened?

Fails due to use of node.js 6.0.0 and 7.6.0 syntax.

Terminal output / screenshots

$ npx eslint .
    3:1   error  Block-scoped variables in non-strict mode are not supported until Node.js 6.0.0. The configured version range is '>=0.10'  node/no-unsupported-features/es-syntax
    3:20  error  Template literals are not supported until Node.js 4.0.0. The configured version range is '>=0.10'                          node/no-unsupported-features/es-syntax
... clipped for briefness
   61:1   error  Async functions are not supported until Node.js 7.6.0. The configured version range is '>=0.10'                            node/no-unsupported-features/es-syntax

Additional information

This is due to eslint-config-gulp including:

{
  "rules": {
    "node/no-unsupported-features/es-syntax": [2, {"version": ">=0.10"}]
  }
}

We could override this in the local .eslintrc to specify a higher version or even remove the version (use the declared package.json#engines.node). I'm not sure if this would mess with the process of updating update-template itself? The other option would be to downgrade the code to comply with node.js 0.10 syntax.