search

gulpjs / vinyl

Virtual file format.
MIT License
1.28k stars 107 forks source link

cleanup node-engine-versions -> fix tests #147

Closed Blaimi closed 4 years ago

Blaimi commented 4 years ago

i.e. drop versions which are EOL and add newer and future ones

phated commented 4 years ago

We have a specific support matrix.

Blaimi commented 4 years ago

ok, I respect that. But obviously the tests are failing for the older versions so IMHO your support marix mentions versions which are not supported in practice — or the tests need an update. But mentioning a support matrix to excuse failing tests is not exactly state of the art.

If you can give me some hints on why the tests are failing I can have a look at them and maybe fix the tests according to the support matrix. As it seems to me by now (without deep investigation) the problem seem to be that one of the libraries dropped support for tge 0.* versions of nodjs. Can you confirm this?