search

gulpjs / vinyl

Virtual file format.
MIT License
1.28k stars 105 forks source link

use Buffer.isBuffer instead of instanceof #58

Closed whyrusleeping closed 9 years ago

whyrusleeping commented 9 years ago

instanceof doesnt work for browserified code

So I changed this to just use Buffer.isBuffer.

probably could just remove the entire 'isBuffer' module, but I left it to be consistent with the other packages.

yocontra commented 9 years ago

module.exports = require('buffer').Buffer.isBuffer would probably be cleanest

whyrusleeping commented 9 years ago

@contra that looks good to me, pushed that up.

whyrusleeping commented 9 years ago

@contra when do you think you could publish a patch version to npm? I understand if you dont want to version bump for such a small change, but it would make my life a little easier as i'm working with browserified vinyl code :)

yocontra commented 9 years ago

0.5.1