GHC_NO_DIRENT_D_TYPE should be defined on Solaris

gulrak / filesystem

An implementation of C++17 std::filesystem for C++11 /C++14/C++17/C++20 on Windows, macOS, Linux and FreeBSD.

MIT License

1.31k stars 168 forks source link

GHC_NO_DIRENT_D_TYPE should be defined on Solaris #142

Closed lhruska closed 2 years ago

lhruska commented 2 years ago

Describe the bug Filesystem fails to compile (filesystem/filesystem.hpp) on Solaris because of missing d_type in dirent structure.

Additional context Doxygen issue

gulrak commented 2 years ago

I'll look into it.

phprus commented 2 years ago

https://github.com/lukyhruska96/doxygen/commit/f751ce0d514def462798352827515126c45037a5

albert-github commented 2 years ago

The reference: https://github.com/doxygen/doxygen/pull/9244/commits/933c0ecb0fdf41054451889ce94115e63ab83333 is better as here also the GHC_OS_SOLARIS is set

gulrak commented 2 years ago

I'll decided against another GHC_NO_DIRENT_D_TYPE and instead removed it and implemented compile time detection of the dirent variant. Got the whole test suite to successfully run on a Solaris 10 and hopefully will make a release until tomorrow. Just need to figure out the GitHub workflow issue with VS2019.

phprus commented 2 years ago

@gulrak CentOS 8 build is failed. Solution: migrate from CentOS 8 to CentOS 8 Stream (like this https://github.com/gulrak/filesystem/pull/140/commits/e8a17c131952c86563ff0ba7e08896a4f2594216)

gulrak commented 2 years ago

Released with v1.5.12.