search

gulrak / filesystem

An implementation of C++17 std::filesystem for C++11 /C++14/C++17/C++20 on Windows, macOS, Linux and FreeBSD.
MIT License
1.34k stars 173 forks source link

vs2013 update5 support #80

Closed ghost closed 3 years ago

ghost commented 3 years ago

as the title

gulrak commented 3 years ago

As I don't have a local installation ov VS2013 available, I would need to rely on Appveyor for that. I'll look into it.

ghost commented 3 years ago

As I don't have a local installation ov VS2013 available, I would need to rely on Appveyor for that. I'll look into it.

I think this is very useful, after all c++17 already has a filesystem, it would be a waste to just use it as a backup!

gulrak commented 3 years ago

Uh... the first test compile looks quite bad...

I understand, that it might be useful to have, but a major requirement of ghc::filesystem is a C++11 capable compiler. From the looks on the errors of that compile, there seem to be a lot of issues with C++11 features still open in VC2013 Update 5. The documented C++11 support table shows quite a list of non-implemented features too. It was already quite some work to support VS2015, but I sure wanted to support it, as a pre-C++17 IDE.

It looks like it would take quite an effort to work around those quirks and not break support for any of the many compilers currently working. An effort that would need time and I would need a local installation, as fixing lots of issues with remote compilation on appveyor only is a difficult task.

I might take another look into it over the next weekend, but my first impression is, that it is out of reach for the time I can invest and I do not plan to generally switch to support C++98/03 in the future, C++11 should stay the minimum requirement. If I find some simple workarounds, maybe, but it doesn't look too promising, I'm sorry.

ghost commented 3 years ago

ok, fine. Maybe I should have chosen boost::filesystem or implemented one myself.

Uh... the first test compile looks quite bad...

I understand, that it might be useful to have, but a major requirement of ghc::filesystem is a C++11 capable compiler. From the looks on the errors of that compile, there seem to be a lot of issues with C++11 features still open in VC2013 Update 5. The documented C++11 support table shows quite a list of non-implemented features too. It was already quite some work to support VS2015, but I sure wanted to support it, as a pre-C++17 IDE.

It looks like it would take quite an effort to work around those quirks and not break support for any of the many compilers currently working. An effort that would need time and I would need a local installation, as fixing lots of issues with remote compilation on appveyor only is a difficult task.

I might take another look into it over the next weekend, but my first impression is, that it is out of reach for the time I can invest and I do not plan to generally switch to support C++98/03 in the future, C++11 should stay the minimum requirement. If I find some simple workarounds, maybe, but it doesn't look too promising, I'm sorry.

gulrak commented 3 years ago

As I expected, it is more work than I can put into it, so without a non breaking PR that doesn't clutter the source too much, VS2013 will stay unsupported. I'm sorry.