search

guma44 / GEOparse

Python library to access Gene Expression Omnibus Database (GEO)
BSD 3-Clause "New" or "Revised" License
144 stars 52 forks source link

fix typo with print function in usage #71

Closed grisaitis closed 3 years ago

CholoTook commented 3 years ago

Why are checks failing for this typo fix?

CholoTook commented 3 years ago

If I had to guess, looking at the log, the test that is running is doing too much work. It's grabbing a very large file (or files) with many samples... (as far as I can tell).

Where is the test written? (Sorry for being lazy ;-)

grisaitis commented 3 years ago

haha i have no idea. good catch and investigation, though.

also this isn't very important, so i might delete if i see in a few months that it's stale

CholoTook commented 3 years ago

Seems a shame to throw away any contribution. The project seems to be making a lot of effort to gather community input, and this is exactly the sort of small thing that builds a community.

Lets see and hope that the maintainer notices soon :-)

On Tue, 15 Jun 2021 at 23:33, William C Grisaitis @.***> wrote:

haha i have no idea. good catch and investigation, though.

also this isn't very important, so i might delete if i see in a few months that it's stale

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/guma44/GEOparse/pull/71#issuecomment-861878678, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANKSZTQZP5BBFVSNYOPI5F3TS7IKRANCNFSM45TC5BYA .

guma44 commented 3 years ago

Hey, thanks a lot. Yeah, the tests need to be rewritten a bit. I like such a small fixes. I agree - it is a good start and makes project better even if this is just a small thing.