gumerov-amir / TTMediaBot

A bot for music streaming to TeamTalk Servers.
https://ttmediabot.ru
MIT License
58 stars 65 forks source link

About TeamTalkSDK #89

Open DalisonCPU opened 1 year ago

DalisonCPU commented 1 year ago

I was looking at the new versions of TeamTalkSDK, and the library was all refactored in version 8.12. The problem that I couldn't run it on TTMediaBOT, because of the acertion errors. I would like to hear from the developers, if they intend to switch to this SDK or if they will continue on TeamTalkSDK 5.8. I suggest that if they are going to continue in TeamTalk 5.8, that TTMediaBOT distributes its own TeamTalkSDK, as it has no way of implementing the missing functions of the library, such as _DoMoveUser, as they will be refused by BearWare, since they are too old.

cyrmax commented 1 year ago

As I remember we could run TTMediaBot on latest TeamTalk 5.12 and it worked normally. Maybe there are some breaking changes but we didn't find them yet. And I am not sure about Linux because I have tested it only on Windows and without actually playing any audio. It was just launch test and some commands.

DalisonCPU commented 1 year ago

Hello. I have several modifications in the TeamTalkSDK and I would like to send them to TTMediaBot. Added the missing _DoMoveUser function and may add some others in the future. But for that, TeamTalkSDK would need to be distributed with TTMediaBot. It's a suggestion, but if you accept it I can send my changes to the SDK that you add to the BOT, since what is being used here is 5.8 and that's what looks best in my opinion. I would take advantage and also send a very nice change that I made to My TTMediaBot. A command that a user can use to pull a bot into a channel, and also functionality that can be turned off and on with an admin command. If activated and no user is in the channel the bot entered, it automatically returns to the initial channel.

DalisonCPU commented 1 year ago

@cyrmax

nunotfc commented 1 year ago

i believe this is a good function, and i woould be very hapy if it goes to official ttmediabot. i see in several teamtalks persons loadin 10 or 20 ttbots, and requesting to admins to move it, or create one for their channels. if this functionalty goes, the user can find for example in root channel all available bot, request one to his channel, and after using, bot returns to the root channel, not keeping to waste resources unecessary in the server or playing audio for noone.

kirill-jjj commented 1 year ago

20 TTMediaBot's? if the bot didn't have memory leaks, it would be possible, but when you using the youtube service, memory leaks, and can go to 600 mb per bot

DalisonCPU commented 1 year ago

it is possible if you have a server that can handle