gumgum / gg-ez-vp

Simple video player with minimal setup, intuitive API and straightforward features
https://gumgum.github.io/gg-ez-vp
MIT License
7 stars 4 forks source link

eneble git releases #105

Closed akiirii closed 3 years ago

akiirii commented 3 years ago

Currently do not release npm packages anymore: https://www.npmjs.com/package/gg-ez-vp -> 1.9.0 • Public • Published a year ago

And also when you try to download it by git releases final package is broken because it does not contain a dist files (it do not do prebuild) -> node_modules/gg-ez-vp contain only:

CHANGELOG.md
LICENSE
package.json
README.md

This PR enables using your package via git release: "gg-ez-vp": "git://github.com/gumgum/gg-ez-vp.git",

edrpls commented 3 years ago

Thank you for your interest and contribution, @akiirii; however, the lack of publishing as a module comes from issue #32, which introduced a logic error when loading the library as a CJS/ES module.

You can read more about this on #106.

We will add this on 2.0.0.