search

gumgum / gg-ez-vp

Simple video player with minimal setup, intuitive API and straightforward features
https://gumgum.github.io/gg-ez-vp
MIT License
7 stars 4 forks source link

Pause VPAID execution until container is large enough #81

Closed edrpls closed 4 years ago

edrpls commented 4 years ago

I'm wondering if this PR should be declined; I was attempting to fix a "delay" with VPAID clickthrough becoming available, but that's just part of a specific VPAID that won't click out before two seconds have passed.

While this change should not affect anything, I'm not sure it provides much value, and may even be a hindrance since the VPAID will have to wait for its container to render before loading, that and I would prefer not adding something unless completely necessary.

edrpls commented 4 years ago

Since the apparent delay is handled by VPAID, this PR is unnecessary.