search

gumgum / gg-ez-vp

Simple video player with minimal setup, intuitive API and straightforward features
https://gumgum.github.io/gg-ez-vp
MIT License
7 stars 4 forks source link

The blocker div is only displayed for VPAID, not VAST #85

Closed edrpls closed 4 years ago

edrpls commented 4 years ago

Describe the bug The div .gg-ez-vp--blocker used to prevent clicks on VPAID thumbnails is needed for VAST as well, since some VAST may try to open their landing page immediately.

To Reproduce

  1. Find a VAST tag without VPAID, it should take over the click for mobile
  2. Click on it
  3. The landing page will open immediately and the gg-ez-vp--blocker won't be rendered

Expected behavior When the blocker is enabled through CSS, no clicks should be allowed to reach the video player.

Additional context The code that creates the blocker div should be extracted from addVPAIDOverlays so that it can be reused by other parts of the code.

Then, that new function should be called before adding VAST tracking.

edrpls commented 4 years ago

Closed by #86