gumyr / bd_warehouse

A build123d parametric part collection
Apache License 2.0
28 stars 12 forks source link

IsoThread, external, fade - bad end #12

Closed gumyr closed 6 months ago

gumyr commented 7 months ago

From bernhard:

md = 20 * MM
p = 3.5 * MM
l = 6 * MM

iso_external = IsoThread(
    major_diameter=md,
    pitch=p,
    length=l,
    external=True,
    end_finishes=("fade", "fade"),
    hand="right",
)

show(iso_external)

image

yeah, it is in _make_fade_end. Currently it uses Plane.XZ for internal and external, but it looks like for external we need Plane.ZY found by trial and error, not sure it is the right fix though

This seems to work when I pass the external parameter into the Thread init function image

But, as I said, can't judge whether this is the root cause or whether it is generically correct.