Closed voneiden closed 10 months ago
You are correct, the dimension check is overly limiting. The fix should be relatively easy; however, we'll need some unit tests to check limits like subtracting from a Vertex, etc. A PR would be great, thanks for the offer.
Boolean subtraction has a built in limitation that checks that all
other
shapes have same dimension asself
.https://github.com/gumyr/build123d/blob/cb5625cbe6bf1220ea82819632c21d6c9a394c58/src/build123d/topology.py#L1692-L1696
This is more limiting as necessary. OpenCascade documentation on Boolean Operations Algorithm states that
Further down the line it is elaborated a bit more:
Therefore, for example, subtracting a 3D shape from a 2D shape is from OpenCascade perspective.
Should be a fairly straightforward fix. I'm open to making a PR if requested.
Thoughts?