search

gumyr / build123d

A python CAD programming library
Apache License 2.0
386 stars 72 forks source link

Swapped width and height in `Face.make_rect` #565

Closed cyberhuman closed 4 months ago

cyberhuman commented 4 months ago

I noticed when trying to use Face.make_rect that it creates a rotated rectangle. I checked the source code and calls OCC's BRepBuilderAPI_MakeFace with halfheight first, then halfwidth: https://github.com/gumyr/build123d/blob/692de83ce238627b66f6a100529b298c6b348758/src/build123d/topology.py#L5409 But the arguments must be UMin, UMax, VMin, VMax. So it must be halfwidth first, then halfheight.

gumyr commented 4 months ago

Fixed with d1877e0debd612d896cf04a397810caac441fa10 Thanks for raising the Issue.