search

gumyr / build123d

A python CAD programming library
Apache License 2.0
382 stars 72 forks source link

Add a test for revolute joints around an axis other than Z #613

Closed zackyancey closed 3 weeks ago

zackyancey commented 2 months ago

This is a test for the bug in #428 . Not sure if I should be targeting dev or joints-v2, since the test currently fails on dev and passes on the other (or if I should be marking this xfail or something).

gumyr commented 3 weeks ago

Thanks for adding this test. I've fixed Issue #428 and tried this test out and it works so please rebase and submit on the dev branch. Thanks again and sorry it took so long to fix the underlying problem.

zackyancey commented 3 weeks ago

Alright, rebased and targeting dev, I ran the tests locally and they passed. Thanks!

gumyr commented 3 weeks ago

Thanks!